[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

[Luboš Luňák via Phabricator via lldb-commits]

llunak added a comment.

In D85145#2191421 <https://reviews.llvm.org/D85145#2191421>, @teemperor wrote:

> Btw, the highlighter supports any kind of delimiter string when 'highlighting' source. So you could add a parameter for a custom highlighter too and then pass a more convenient highlighter 'style' in to make the parsing simpler. See the only call MakeVimStyle (which generates the style that adds the color escapes) and the HighlighterStyle where you can set any kind of delimiter.

I think I don't want to do that. The gui mode should preferably use the same highlighting as the non-gui one, so if I added a new style, the colors would still need to be mapped somewhen. Moreover the ^[<color>m style parser is actually pretty simple, much simpler than I was originally afraid it'd be, and possibly it could be later needed for something else too.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85145/new/

https://reviews.llvm.org/D85145