[Lldb-commits] [PATCH] D84475: [lldb] Inform every language runtime of the modified modules

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 24 11:39:20 PDT 2020


clayborg accepted this revision.
clayborg added a comment.

LGTM with a few nits that can be fixed if needed



================
Comment at: lldb/source/Target/Process.cpp:5762-5764
   if (sys_runtime) {
     sys_runtime->ModulesDidLoad(module_list);
   }
----------------
remove braces?


================
Comment at: lldb/source/Target/Process.cpp:5772-5774
+  for (auto &runtime : m_instrumentation_runtimes) {
+    runtime.second->ModulesDidLoad(module_list);
   }
----------------
remove braces now that this is just a single line


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84475/new/

https://reviews.llvm.org/D84475





More information about the lldb-commits mailing list