[Lldb-commits] [PATCH] D84480: debugserver: Support ios simulator load command disambiguation in qProcessInfo

[Frederic Riss via Phabricator via lldb-commits]

friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lldb/tools/debugserver/source/DNB.cpp:1396
   if (GetProcessSP(pid, procSP)) {
-    // FIXME: This doesn't correct for older ios simulator and macCatalyst.
+    // FIXME: This doesn't correct for macCatalyst.
     auto info = procSP->GetDeploymentInfo(lc, load_command_address);
----------------
`s/doesn't/isn't/` ?


================
Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:782-783
-      // Simulator support. If the platform is ambiguous, use the dyld info.
-      if (deployment_info.maybe_simulator) {
-        if (deployment_info.maybe_simulator) {
-#if (defined(__x86_64__) || defined(__i386__))
----------------
I guess at this point we were really sure it was maybe a simulator :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84480/new/

https://reviews.llvm.org/D84480