[Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

[Jonas Devlieghere via lldb-commits]

On Thu, Jul 23, 2020 at 00:20 Pavel Labath <pavel at labath.sk> wrote:

> On 22/07/2020 22:56, Jonas Devlieghere via lldb-commits wrote:
> > -  ConstString operator=(ConstString rhs) {
> > +  ConstString operator=(const ConstString &rhs) {
>
> ConstString is trivially copyable (well, it has a user defined copy
> constructor but it is trivial...).
>
> Plus, not so long ago (D59030) we changed all `const ConstString &`s to
> plain `ConstString`. It would be good to avoid flipping this back and
> forth all the time.


Thanks for reminding me, I had totally forgotten about that patch. I’ll
take care of that tomorrow.
-- 
Sent from my iPhone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200723/d42eed5a/attachment.html>