[Lldb-commits] [lldb] 138244f - [lldb] fix warnings in TestOptionValueFileColonLine.cpp

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 20 21:44:51 PDT 2020


Author: Jonas Devlieghere
Date: 2020-07-20T21:43:17-07:00
New Revision: 138244f099063517f8de37087d61a9005d40b95f

URL: https://github.com/llvm/llvm-project/commit/138244f099063517f8de37087d61a9005d40b95f
DIFF: https://github.com/llvm/llvm-project/commit/138244f099063517f8de37087d61a9005d40b95f.diff

LOG: [lldb] fix warnings in TestOptionValueFileColonLine.cpp

Added: 
    

Modified: 
    lldb/unittests/Interpreter/TestOptionValueFileColonLine.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Interpreter/TestOptionValueFileColonLine.cpp b/lldb/unittests/Interpreter/TestOptionValueFileColonLine.cpp
index e5b2c77a1616..54e31333d835 100644
--- a/lldb/unittests/Interpreter/TestOptionValueFileColonLine.cpp
+++ b/lldb/unittests/Interpreter/TestOptionValueFileColonLine.cpp
@@ -14,8 +14,8 @@
 using namespace lldb_private;
 
 void CheckSetting(const char *input, bool success, const char *path = nullptr,
-                  uint32_t line_number = LLDB_INVALID_ADDRESS,
-                  uint32_t column_number = 0) {
+                  uint32_t line_number = LLDB_INVALID_LINE_NUMBER,
+                  uint32_t column_number = LLDB_INVALID_COLUMN_NUMBER) {
 
   OptionValueFileColonLine value;
   Status error;
@@ -38,8 +38,10 @@ TEST(OptionValueFileColonLine, setFromString) {
   Status error;
 
   // Make sure a default constructed value is invalid:
-  ASSERT_EQ(value.GetLineNumber(), LLDB_INVALID_LINE_NUMBER);
-  ASSERT_EQ(value.GetColumnNumber(), 0);
+  ASSERT_EQ(value.GetLineNumber(),
+            static_cast<uint32_t>(LLDB_INVALID_LINE_NUMBER));
+  ASSERT_EQ(value.GetColumnNumber(),
+            static_cast<uint32_t>(LLDB_INVALID_COLUMN_NUMBER));
   ASSERT_FALSE(value.GetFileSpec());
 
   // Make sure it is an error to pass a specifier with no line number:


        


More information about the lldb-commits mailing list