[Lldb-commits] [PATCH] D83600: Add a decorator to skip tests when running under Rosetta

[Davide Italiano via Phabricator via lldb-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

Good, one minor suggestion.



================
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:560
+            return False
+        return platform.uname()[5] == "arm" and self.getArchitecture() == "x86_64"
+    return skipTestIfFn(is_running_rosetta, bugnumber)(func)
----------------
There might be a more direct way of checking this, maybe `machine()`. We used `platform().uname()` for internal limitations & machine not always returning the right string, but it should be fixed on Beta 1 (and beyond) for sure


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83600/new/

https://reviews.llvm.org/D83600