[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

Other than a quibble about using _sp suffix, this is fine.



================
Comment at: lldb/source/Core/ValueObject.cpp:693
+  if (!valobj && synthetic_array_member) {
+    if (ValueObjectSP synth_valobj = GetSyntheticValue()) {
+      valobj =
----------------
We usually use _sp suffix for shared pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83327/new/

https://reviews.llvm.org/D83327