[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

[Vedant Kumar via Phabricator via lldb-commits]

vsk added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1750
+        # (unique) test name is used instead.
+        inline_name = None
+        for attrname, attrvalue in attrs.items():
----------------
Is `inline_suffix = attrs.get('__inline_name__')` no good?


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1778
 
-                    method_name = attrname + "_" + cat
+                    test_name = inline_name if inline_name else attrname
+                    method_name = test_name + "_" + cat
----------------
Would it be all right to unconditionally set `method_name = name + attrname + cat`?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81516/new/

https://reviews.llvm.org/D81516