[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 9 04:54:05 PDT 2020


jankratochvil marked 4 inline comments as done.
jankratochvil added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:733
   DWARFAttributes attributes;
-  GetAttributes(cu, attributes);
+  GetAttributes(cu, attributes, 0 /* curr_depth */);
   return GetParentDeclContextDIE(cu, attributes);
----------------
labath wrote:
> I guess this could keep calling the public version of this function without the extra argument.
It was intentional but in fact you are right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81423/new/

https://reviews.llvm.org/D81423





More information about the lldb-commits mailing list