[Lldb-commits] [lldb] c34936d - [lldb] s/dyn_cast/isa

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue May 26 00:26:41 PDT 2020


Author: Pavel Labath
Date: 2020-05-26T09:21:54+02:00
New Revision: c34936dae734085c4bc01703da0f5b7456e1bf51

URL: https://github.com/llvm/llvm-project/commit/c34936dae734085c4bc01703da0f5b7456e1bf51
DIFF: https://github.com/llvm/llvm-project/commit/c34936dae734085c4bc01703da0f5b7456e1bf51.diff

LOG: [lldb] s/dyn_cast/isa

The cast result is unused and produces a warning with gcc.

Added: 
    

Modified: 
    lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index c687251ed5dc..9ff8bdb7537f 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -344,7 +344,7 @@ static void SetMemberOwningModule(clang::Decl *member,
   member->setFromASTFile();
   member->setOwningModuleID(id.GetValue());
   member->setModuleOwnershipKind(clang::Decl::ModuleOwnershipKind::Visible);
-  if (auto *nd = llvm::dyn_cast<clang::NamedDecl>(member))
+  if (llvm::isa<clang::NamedDecl>(member))
     if (auto *dc = llvm::dyn_cast<clang::DeclContext>(parent)) {
       dc->setHasExternalVisibleStorage(true);
       // This triggers ExternalASTSource::FindExternalVisibleDeclsByName() to be


        


More information about the lldb-commits mailing list