[Lldb-commits] [PATCH] D80308: [lldb] Enable C++14 when evaluating expressions in a C++14 frame

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/test/API/lang/cpp/standards/cpp14/TestCPP14Standard.py:19
+        # polymorphic lambdas).
+        self.expect_expr("[](auto x) { return x; }(1)", result_type="int", result_value="1")
----------------
teemperor wrote:
> shafik wrote:
> > It would be worth it to add a more complete set of C++14 tests. [p1319r0](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1319r0.html) covers the C++11 to C++14 differences. 
> > 
> > Especially ones that may not work so we can file bugs for these and track them.
> We're only checking that the right Clang language standard was set, not Clang's C++ features related to that set standard (which should be and probably already is a test in Clang).
Well, yes and no. We have seen features that should work because clang supports it but don't because of other reasons such as variadic templates and structured bindings. So just because clang supports it does not mean it won't break in expressions because of some other reason. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80308/new/

https://reviews.llvm.org/D80308