[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 22 03:36:39 PDT 2020


teemperor accepted this revision.
teemperor added a comment.

I think the refactoring is a good idea, but IMHO this patch can go in as-is. It's not adding any more debt to the existing approach (it even deletes code) and it adds tests, so I don't see a drawback of merging this. Also having this bug fixed with a small back portable patch seems better than doing it with some big refactor.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80254/new/

https://reviews.llvm.org/D80254





More information about the lldb-commits mailing list