[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 20 17:08:00 PDT 2020


clayborg added a comment.

This looks good, thanks for subscribing me. We need to have GetNumChildren and GetChildAtIndex agreeing on things and we definitely shouldn't be walking more than on pointer recursively. My only question is do we need helper functions added to TypeSystemClang to avoid this issue since we have GetNumChildren and GetChildAtIndex doing things differently? Some function both could/should be calling so that things can't get out of sync?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80254/new/

https://reviews.llvm.org/D80254





More information about the lldb-commits mailing list