[Lldb-commits] [PATCH] D79777: Fix error in TestNumThreads.py when frame.GetFunctionName returns none

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid created this revision.
omjavaid added a reviewer: labath.
Herald added a subscriber: kristof.beyls.

This patch fixes an error happening in TestNumThreads.py when it encounters frame.GetFunctionName none for address only locations in stripped libc.

This error was showing up on arm-linux docker container running lldb buildbot.


https://reviews.llvm.org/D79777

Files:
  lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py


Index: lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
===================================================================
--- lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
+++ lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
@@ -95,6 +95,8 @@
         # the same breakpoint.
         def is_thread3(thread):
             for frame in thread:
+                if frame.GetFunctionName() is None:
+                    continue
                 if "thread3" in frame.GetFunctionName(): return True
             return False
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79777.263403.patch
Type: text/x-patch
Size: 582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200512/d46ffd5c/attachment.bin>