[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

Sat May 9 11:09:07 PDT 2020

JDevlieghere added inline comments.

================
Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1625

+    // When called from the `shell` alias with no argument, exit.
+    if (args.GetRawPart().empty())
----------------
Is this only true for the alias?

================
Comment at: lldb/test/API/commands/shell/TestShellCommand.py:27
+        triple = self.dbg.GetSelectedPlatform().GetTriple()
+        if re.match(".*-.*-windows", triple):
+            self.expect("shell dir c:\\", substrs=["Windows", "Program Files"])
----------------
I assume you copied this from `TestPlatformCommand.py` but if the test is skipped on Windows we can probably remove this line here. 

On that note, I think we could avoid some code duplication by merging these tests and have the same tests, once called with `shell` and once with `platform shell`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79659/new/

https://reviews.llvm.org/D79659