[Lldb-commits] [PATCH] D79603: Add an API to construct an XcodeSDK from an SDK type.

[Vedant Kumar via Phabricator via lldb-commits]

vsk added inline comments.


================
Comment at: lldb/source/Utility/XcodeSDK.cpp:44
+  }
+  static_assert(XcodeSDK::Linux == XcodeSDK::numSDKTypes - 1,
+                "New SDK type was added, update this list!");
----------------
I'd expect -Wcovered-switch to break the build if a new case gets added and this list isn't updated. Wdyt of dropping numSDKTypes and using an llvm_unreachable here instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79603/new/

https://reviews.llvm.org/D79603