[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 4 inline comments as done.
mib added inline comments.


================
Comment at: lldb/source/Core/ValueObject.cpp:52
 
+#include "Plugins/TypeSystem/Clang/TypeSystemClang.h"
+
----------------
friss wrote:
> You don't want to introduce a dependency between Core and a plugin. What you need here might need to be introduced as a new abstract functionality on the TypeSystem base class.
I'll change this before updating the differential with the fixes.


================
Comment at: lldb/source/Core/ValueObject.cpp:2846
+      if (llvm::isa<TypeSystemClang>(compiler_type.GetTypeSystem())) {
+        if (HasSyntheticValue()) {
+          TargetSP target_sp = GetTargetSP();
----------------
friss wrote:
> I am understanding correctly that this condition will only trigger when there's a synthetic child provider for the type? In other words, if we have an opaque pointer that we don't know how to display, it will still cause an error, right?
Yes, from my understanding, if the opaque pointer doesn't have any synthetic child provider, it won't have a synthetic value and lldb should error saying `error: dereference failed`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79554/new/

https://reviews.llvm.org/D79554