[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 7 05:03:37 PDT 2020


labath marked an inline comment as done.
labath added inline comments.


================
Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py:5
+
+supported_archs = ["x86_64", "arm", "aarch64"]
+
----------------
djtodoro wrote:
> I haven't refreshed the page before submitting my previous comment.
> 
> WDYT about adding a decorators-function (e.g. `skipUnlessEntryValuesSupportedArch`) so we can use it in other tests as well?
I think that's a good idea, and that the check can be folded into the existing `skipUnlessHasCallSiteInfo` decorator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79491/new/

https://reviews.llvm.org/D79491





More information about the lldb-commits mailing list