[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM modulo the inline comment.



================
Comment at: lldb/include/lldb/Host/HostInfoBase.h:96
   /// Return the directory containing a specific Xcode SDK.
-  static std::string GetXcodeSDK(XcodeSDK sdk) { return {}; }
+  static llvm::StringRef GetXcodeSDKPath(XcodeSDK sdk) { return {}; }
 
----------------
This should probably be named `GetXcodeSDKDirectory` for consistency with the other methods. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79364/new/

https://reviews.llvm.org/D79364