[Lldb-commits] [lldb] 6b8d6f4 - [lldb/test] Fix wrong target command failure message on Windows

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Mon May 4 10:22:48 PDT 2020


Author: Med Ismail Bennani
Date: 2020-05-04T19:22:34+02:00
New Revision: 6b8d6f44592cd975919d535483c2aca7cd7857b8

URL: https://github.com/llvm/llvm-project/commit/6b8d6f44592cd975919d535483c2aca7cd7857b8
DIFF: https://github.com/llvm/llvm-project/commit/6b8d6f44592cd975919d535483c2aca7cd7857b8.diff

LOG: [lldb/test] Fix wrong target command failure message on Windows

This patch fixes the test failure happening on Windows introduced by
`015117411e11458f9816ba4359246132164a4297`.

Since the failure message comes from the OS, the test needs to support both
UNIX and Windows messages.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>

Added: 
    

Modified: 
    lldb/test/API/commands/target/basic/TestTargetCommand.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/target/basic/TestTargetCommand.py b/lldb/test/API/commands/target/basic/TestTargetCommand.py
index 8335753c78af..2704e0ed25ad 100644
--- a/lldb/test/API/commands/target/basic/TestTargetCommand.py
+++ b/lldb/test/API/commands/target/basic/TestTargetCommand.py
@@ -326,7 +326,7 @@ def test_target_create_multiple_args(self):
     @no_debug_info_test
     def test_target_create_nonexistent_core_file(self):
         self.expect("target create -c doesntexist", error=True,
-                    substrs=["Cannot open 'doesntexist': No such file or directory"])
+                    patterns=["Cannot open 'doesntexist'", ": (No such file or directory|The system cannot find the file specified)"])
 
     # Write only files don't seem to be supported on Windows.
     @skipIfWindows
@@ -340,7 +340,7 @@ def test_target_create_unreadable_core_file(self):
     @no_debug_info_test
     def test_target_create_nonexistent_sym_file(self):
         self.expect("target create -s doesntexist doesntexisteither", error=True,
-                    substrs=["Cannot open '", "': No such file or directory"])
+                    patterns=["Cannot open '", ": (No such file or directory|The system cannot find the file specified)"])
 
     @skipIfWindows
     @no_debug_info_test


        


More information about the lldb-commits mailing list