[Lldb-commits] [lldb] 116c2da - [lldb/Scripts] proc.returncode is set in proc.communicate

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 21 11:30:26 PDT 2020


Author: Jonas Devlieghere
Date: 2020-04-21T11:30:15-07:00
New Revision: 116c2da4b2505af98c1b9652c8f280ec8147d27e

URL: https://github.com/llvm/llvm-project/commit/116c2da4b2505af98c1b9652c8f280ec8147d27e
DIFF: https://github.com/llvm/llvm-project/commit/116c2da4b2505af98c1b9652c8f280ec8147d27e.diff

LOG: [lldb/Scripts] proc.returncode is set in proc.communicate

Make sure proc.returncode has been assigned before we compare it to 0.

Added: 
    

Modified: 
    lldb/scripts/reproducer-replay.py

Removed: 
    


################################################################################
diff  --git a/lldb/scripts/reproducer-replay.py b/lldb/scripts/reproducer-replay.py
index f16d6e8b146c..4dd347058342 100755
--- a/lldb/scripts/reproducer-replay.py
+++ b/lldb/scripts/reproducer-replay.py
@@ -15,8 +15,8 @@ def run_reproducer(path):
                             stderr=subprocess.PIPE)
     reason = None
     try:
-        success = proc.returncode == 0
         outs, errs = proc.communicate(timeout=TIMEOUT)
+        success = proc.returncode == 0
         result = 'PASSED' if success else 'FAILED'
         if not success:
             outs = outs.decode()


        


More information about the lldb-commits mailing list