[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked an inline comment as done.
jankratochvil added inline comments.


================
Comment at: lldb/docs/resources/test.rst:45
+build around checking the output of ``lldb`` (the command line driver) or
+``lldb-test`` using ``FileCheck``. Shell tests are generally small and fast to
+write because they require little boilerplate.
----------------
JDevlieghere wrote:
> jankratochvil wrote:
> > https://llvm.org/docs/CommandGuide/FileCheck.html
> You can't combine preformatted text with links, so I've added the link above and kept it preformatted here. 
OK, sure I am fine with that, thanks.


================
Comment at: lldb/docs/resources/test.rst:59
+from the command line driver with ``b main``` or you could use the SB API and do
+something like ``target.BreakpointCreateByName``.
+
----------------
JDevlieghere wrote:
> jankratochvil wrote:
> > https://lldb.llvm.org/python_reference/lldb.SBTarget-class.html#BreakpointCreateByName
> Same issue as mentioned earlier. Let me know if you prefer the link over the preformatted text.
Up to you but I find it convenient for lazy readers to have the links there to get more involved into the framework.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78242/new/

https://reviews.llvm.org/D78242