[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D77047#1966539 <https://reviews.llvm.org/D77047#1966539>, @omjavaid wrote:

> @labath Core file FP register access is not supported on AArch64. I am working on a follow up patch to fix it. This patch only has linux changes so can we get this through?


This patch is a bit big and basically untested (an unconditionally skipped test hardly counts), so I am looking for ways to split it up and add some test coverage. I'm also worried about copying what appear to be chunks of linux header files...



================
Comment at: lldb/source/Plugins/Process/Linux/NativeThreadLinux.h:42-43
   NativeRegisterContextLinux &GetRegisterContext() override {
+    if (m_reg_context_up && IsStopped(nullptr))
+      m_reg_context_up->ConfigureRegisterContext();
+
----------------
Why can't this work be done in the register context constructor? I believe we are always creating a Thread (and its reg context) while it is stopped...


================
Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextRegisterInfo.h:38-40
+  uint32_t SetRegisterInfoMode(uint32_t mode) {
+    return m_register_info_interface_up->SetRegisterInfoMode(mode);
+  }
----------------
I can't find any callers of this function. Who is calling it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77047/new/

https://reviews.llvm.org/D77047