[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

Christopher Tetreault via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 8 13:35:37 PDT 2020


ctetreau added a comment.

In D77587#1965604 <https://reviews.llvm.org/D77587#1965604>, @efriedma wrote:

> If I'm following correctly, this should apply on its own.  Then you're expecting the following API changes:
>
> 1. getNumElements() will move from VectorType to FixedVectorType.  Existing code will be changed to either cast to FixedVectorType, or switch to using getElementCount().
> 2. Maybe remove the default argument from VectorType::get()
>
>   Does that sound right?


This is basically the plan:

1. Add the new types and functions
2. Fix up usages of getNumElements()
3. move getNumElements() and getMinNumElements() into the derived classes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77587/new/

https://reviews.llvm.org/D77587





More information about the lldb-commits mailing list