[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 6 02:08:32 PDT 2020


labath added a comment.

Checking for presence this way seems ok-ish (definitely better than the environment variable). A possible alternative would be to pass some argument to dotest from cmake which would identify the status of the pt support.

Anyway, if you're going to add a new public API for this purpose, please create a separate patch for that with a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77452/new/

https://reviews.llvm.org/D77452





More information about the lldb-commits mailing list