[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid marked an inline comment as done.
omjavaid added a comment.

In D77045#1954690 <https://reviews.llvm.org/D77045#1954690>, @labath wrote:

> This sounds like it could use a test case.


Adding a testcase would be tricky as these register overlap in memory and we store them with overlapping offsets with their children we should not need to invalidate the children when we write the parent but for some strange unexplainable reason QEMU was behaving strangely and not updating the first half in certain random cases. I just thought invalidation of children will force a read after write for that case.



================
Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h:593-594
 
+#define STRINGIZE2(x) #x
+#define STRINGIZE(x) STRINGIZE2(x)
+
----------------
labath wrote:
> What's up with the indirection?
We want to pass nullptr or register name as is then do stringize on regname only. According to C macro expansion rules if we want our macros expanded first and then do the # then we ll need double indirection.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77045/new/

https://reviews.llvm.org/D77045