[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

Thu Mar 26 10:18:13 PDT 2020

emrekultursay marked 3 inline comments as done.
emrekultursay added a comment.

In D76806#1943062 <https://reviews.llvm.org/D76806#1943062>, @labath wrote:

> It's not clear to me what is the user-visible effect of this. It sounds like there should be one, but I don't know what it is...

If LLDB will cache FileSP shared pointers, there should be only one place for caching, and it's the Source File Cache, which can be enabled/disabled by the user. 
User-facing effect of this change can be found in bug: llvm.org/PR45310

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76806/new/

https://reviews.llvm.org/D76806