[Lldb-commits] [PATCH] D76529: [lldb-vscode] Add missing launchCommands entry in the package.json

Fri Mar 20 17:23:03 PDT 2020

clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.

================
Comment at: lldb/tools/lldb-vscode/package.json:150
+									"type": "array",
+									"description": "Commands that create a custom target instead of using lldb-vscode's default target creation.",
+									"default": []
----------------
This needs a better description that is more akin to the "attachCommands". Maybe something like:

```
Custom commands that are executed instead of launching a process. A target will be created with the launch arguments prior to executing these commands. The commands may optionally create a new target and must perform a launch. A valid process must exist after these commands complete or the \"launch\" will fail.
``` 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76529/new/

https://reviews.llvm.org/D76529