[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[James Henderson via Phabricator via lldb-commits]

jhenderson added a comment.

@HsiangKai, have you noticed that there are some test failures according to the harbourmaster bot? They look like they could be related to this somehow.



================
Comment at: llvm/unittests/Support/ELFAttributeParserTest.cpp:21
+  Error handler(uint64_t tag, bool &handled) {
+    // Dummy function. There is no attribute need to be handled.
+    handled = true;
----------------
I might suggest changing this comment to "Treat all attributes as handled."


================
Comment at: llvm/unittests/Support/ELFAttributeParserTest.cpp:27
+public:
+  AttributeHeaderParser(ScopedPrinter *sw)
+      : ELFAttributeParser(sw, emptyTagNameMap, "test") {}
----------------
`sw` seems a bit of a random name. What does it mean?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023