[Lldb-commits] [PATCH] D76411: [debugserver] Implement hardware breakpoints for ARM64

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 19 12:00:09 PDT 2020


jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

Nice patch, thanks for doing this.  I wouldn't have added the fallback code in `DNBArchMachARM64::NumSupportedHardwareBreakpoints` to handle the case where the sysctl fails - it doesn't fail -  but there's no harm in it.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76411/new/

https://reviews.llvm.org/D76411





More information about the lldb-commits mailing list