[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

Thu Mar 19 07:32:11 PDT 2020

friss marked an inline comment as done.
friss added a comment.

In D76407#1930693 <https://reviews.llvm.org/D76407#1930693>, @labath wrote:

> Could the inferior manually wipe the crash annotation?

This is not something you're supposed to wipe. It's additional information that is going to b dumped in the crashlog if the process crashes. If dyld runs in some kind of degraded mode, it will put this annotation there at program startup time and never remove it.

================
Comment at: lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py:72

-    def test_on_sane_process(self):
-        """Test that lldb doesn't fetch the extended crash information
----------------
mib wrote:
> What about adding a `@skipIfDarwinEmbedded` decorator for this test ? IIUC, it would skip the test of Darwin armv7/arm64 targets (iOS) but still run on other platforms.
I could do this, and it would fix the issue I'm seeing. I chose to remove it completely, because there's no guarantee that what the test exercises is true. But I guess I can just `@skipIfDarwinEmbedded` now and we'll see if the test causes any more trouble in other scenarios

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76407/new/

https://reviews.llvm.org/D76407