[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: aprantl.
Herald added a subscriber: mgorny.

The current implementation isn't very resilient when it comes to the output of `xcrun`. Currently it cannot deal with:

- Trailing newlines.
- Leading newlines and errors/warnings before the Xcode path.
- Xcode not being named `Xcode.app`.

This extract the logic into a helper in PlatformMacOSX and fixes those issues.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D76261

Files:
  lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
  lldb/unittests/Platform/CMakeLists.txt
  lldb/unittests/Platform/PlatformMacOSXTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76261.250654.patch
Type: text/x-patch
Size: 10164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200316/43f30a15/attachment.bin>