[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

Fri Mar 13 09:39:52 PDT 2020

aprantl marked an inline comment as done.
aprantl added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:224
+    if (auto *rd = llvm::dyn_cast<clang::RecordDecl>(tag_decl))
+      for (auto *f : rd->fields())
+        TypeSystemClang::SetOwningModule(f, owning_module);
----------------
aprantl wrote:
> labath wrote:
> > Maybe spell out the type here? I have no idea what's the type of this..
> Yeah, this should either be a Visitor or in our ASTImporterDelegate in lldb.
Another comment from an in-person discussion with @teemperor: We probably should not attach owning module information in the scratch/expression context.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75488/new/

https://reviews.llvm.org/D75488