[Lldb-commits] [lldb] e3fc6b3 - [lldb][NFC] Fix unsigned/signed comparison warning in SymbolFileDWARFTest.cpp

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 12 07:31:12 PDT 2020


Author: Raphael Isemann
Date: 2020-03-12T15:30:11+01:00
New Revision: e3fc6b3c346f583adbdb38b0935cc73439aaad99

URL: https://github.com/llvm/llvm-project/commit/e3fc6b3c346f583adbdb38b0935cc73439aaad99
DIFF: https://github.com/llvm/llvm-project/commit/e3fc6b3c346f583adbdb38b0935cc73439aaad99.diff

LOG: [lldb][NFC] Fix unsigned/signed comparison warning in SymbolFileDWARFTest.cpp

offset_t is unsigned, so if the RHS is signed we get a warning from clang:
    warning: comparison of integers of different signs: 'const unsigned long long' and 'const int'

Added: 
    

Modified: 
    lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp b/lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
index f1010a100bfd..8bf019ea9ed6 100644
--- a/lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
+++ b/lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
@@ -344,5 +344,5 @@ TEST_F(SymbolFileDWARFTests, ParseArangesNonzeroSegmentSize) {
   EXPECT_TRUE(bool(error));
   EXPECT_EQ("segmented arange entries are not supported",
             llvm::toString(std::move(error)));
-  EXPECT_EQ(off, 12); // Parser should read no further than the segment size
+  EXPECT_EQ(off, 12U); // Parser should read no further than the segment size
 }


        


More information about the lldb-commits mailing list