[Lldb-commits] [PATCH] D75418: tab completion for process signal

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 6 08:46:16 PST 2020


teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

I would like to have a test for this without a running process but otherwise this LGTM. Thanks a lot!



================
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:97
+                              ['SIGABRT',
+                               'SIGALRM'])
+
----------------
Could you make another test case that is trying tab completion without a running process? That should just provide no completions and not crash or something like that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75418/new/

https://reviews.llvm.org/D75418





More information about the lldb-commits mailing list