[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 2 01:06:04 PST 2020


labath added a comment.

This looks fine, but I think you'll first need to handle the lit changes to allow skipping tests. Otherwise all of the pdb and breakpad tests will break once you do this. I guess the reason that this hasn't happened yet is because you have a typo in your cache file.



================
Comment at: lldb/source/API/SBCommandReturnObject.cpp:98-101
+  std::ofstream reproducer_log_file;
+  reproducer_log_file.open(lldb_private::repro::Reproducer::Instance().IsCapturing() ? "/tmp/capture.log" : "/tmp/replay.log", std::fstream::app);
+  reproducer_log_file << output.AsCString(/*value_if_empty*/ "") << "\n";
+  reproducer_log_file.close();
----------------
?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73016/new/

https://reviews.llvm.org/D73016





More information about the lldb-commits mailing list