[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, teemperor.
Herald added a subscriber: abidh.
Herald added a project: LLDB.
JDevlieghere edited the summary of this revision.
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM, let’s send that code to the shadow realm.


The PluginManager contains a lot of duplicate code. I already removed a bunch of it by introducing a the templated PluginInstance class, and this is the next step in the process.

There's a lot more that can be done, but for these kind of changes I like to work incrementally. Given that this touches a lot of code I'd appreciate a second set of eyes to spot any mistakes.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D74816

Files:
  lldb/source/Core/PluginManager.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74816.245334.patch
Type: text/x-patch
Size: 76699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200219/1a16dc1a/attachment-0001.bin>