[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with the inline comments addressed and a test in `Shell/VSCode`.



================
Comment at: lldb/tools/lldb-vscode/CMakeLists.txt:20
 
+
 # We need to include the llvm components we depend on manually, as liblldb does
----------------
Spurious newline


================
Comment at: lldb/tools/lldb-vscode/CMakeLists.txt:25
+set(LLVM_TARGET_DEFINITIONS Opts.td)
+tablegen(LLVM Opts.inc -gen-opt-parser-defs)
+add_public_tablegen_target(LLDBVSCodeOptionsTableGen)
----------------
Please use `Options.td` for consistency with the lldb driver.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74798/new/

https://reviews.llvm.org/D74798