[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

Mon Feb 17 03:50:16 PST 2020

jankratochvil added a comment.

In D74637#1878720 <https://reviews.llvm.org/D74637#1878720>, @labath wrote:

> the MainCU is stored in the DIERef, which you now say you want to change.

Just some wording: If MainCU was in `DIERef` then MainCU needs to be also in `DWARFDIE` which means `DWARFDIE` must grow 16->24 bytes which you do not want. So transitively yes, I cannot store MainCU into `DIERef`.

> Suppose these patches are accepted (let's call them tentatively accepted). What would be the next steps?

I find this patch as a NFC cleanup to the codebase - to satisfy a new premise `user_id_t` is used as little as possible and thus only for external interfaces which must not deal with MainCU in any way.
Its larger goal is to satisfy this item of the big DWZ plan you made <https://reviews.llvm.org/D73206#1871895>:

> I think it would be good to have only one kind of "user id". What are the cases where you need a main-cu-less user id?

Sure thanks for all the reviews.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74637/new/

https://reviews.llvm.org/D74637