[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Ok, let's give this one more try. I have a couple of inline comments for the further simplification of the test case.



================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWasm.py:60
+    def haltReason(self):
+        return "T05thread-pcs:" + format(self.current_pc, 'x') + ";thread:1;"
+
----------------
you don't need the `thread-pcs:` part here, when you're implementing `readRegister`. thread-pcs is a preformance optimization, but we don't care about that in a test.


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWasm.py:191-201
+        class Responder(MyResponder):
+
+            def __init__(self, obj_path):
+                MyResponder.__init__(self, obj_path)
+
+            def qXferRead(self, obj, annex, offset, length):
+                if obj == "libraries":
----------------
Could you remove this class (you can e.g. make the module name configurable via the object constructor)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72751/new/

https://reviews.llvm.org/D72751