[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

Frederic Riss via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 6 17:38:27 PST 2020


friss added inline comments.


================
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98
+  bool IsMangledName(llvm::StringRef name) const override {
+    return false;
+  }
----------------
The original code was calling `IsPossibleObjCMethodName` and it looks like you completely lose this codepath with this rewrite. Unclear to me if it's the right thing to return here, but that's definitely a change in behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74187/new/

https://reviews.llvm.org/D74187





More information about the lldb-commits mailing list