[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/source/Target/StackFrameRecognizer.cpp:95
     const SymbolContext &symctx =
-        frame->GetSymbolContext(eSymbolContextModule | eSymbolContextFunction);
+        frame->GetSymbolContext(eSymbolContextEverything);
     ConstString function_name = symctx.GetFunctionName();
----------------
friss wrote:
> What's the reason of this change?
In line 101, lldb tries to get the symbol from the symbol context. If the symbol was not populated in the SymbolContext before calling `GetRecognizerForFrame` then it's null and the function returns a `StackFrameRecognizerSP`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73303/new/

https://reviews.llvm.org/D73303