[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it.

Tue Feb 4 10:31:13 PST 2020

vsk added inline comments.

================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:14
 // On device doesn't have supporty for XPC.
 #if defined(__APPLE__) && (defined(__arm64__) || defined(__aarch64__))
 #define NO_XPC_SERVICES 1
----------------
This is missing `__arm__`, right? Why not just include TargetConditionals.h and change the the check to TARGET_OS_EMBEDDED?

https://opensource.apple.com/source/CarbonHeaders/CarbonHeaders-18.1/TargetConditionals.h

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73938/new/

https://reviews.llvm.org/D73938