[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

[Vedant Kumar via Phabricator via lldb-commits]

vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: lldb/source/Utility/DataExtractor.cpp:610
   int64_t sval64 = GetMaxS64(offset_ptr, size);
   if (bitfield_bit_size > 0) {
     int32_t lsbcount = bitfield_bit_offset;
----------------
shafik wrote:
> We could do an early exit if `bitfield_bit_size` is zero.
Yes, I think that'd simplify things. I'll do this in a follow up commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73913/new/

https://reviews.llvm.org/D73913