[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 31 14:35:04 PST 2020


vsk updated this revision to Diff 241814.
vsk edited the summary of this revision.
vsk added a comment.

- Go with @gclayton's original suggestion, as it's proven to be impractical to alter the notion of a Value's size in the Value/ValueObject logic.
- I've tested this and gotten a clean check-lldb run. The added tests now pass ASan-clean.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73148/new/

https://reviews.llvm.org/D73148

Files:
  lldb/packages/Python/lldbsuite/test/functionalities/optimized_code/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/optimized_code/TestNoASanExceptionAfterEvalOP_piece.py
  lldb/packages/Python/lldbsuite/test/functionalities/optimized_code/main.cpp
  lldb/source/Core/ValueObjectVariable.cpp
  lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-smaller-than-struct.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73148.241814.patch
Type: text/x-patch
Size: 9250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200131/d3d1ad5f/attachment-0001.bin>


More information about the lldb-commits mailing list