[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 30 23:47:15 PST 2020


teemperor added a comment.

I'm very much in favor of making this more strict by default. My only problem is that the current error message is really cryptic:

  AssertionError: False is not True : 'expr --show-types -- *(StgClosure*)$r14' returns expected result, got '(StgClosure) $3 = {
    (StgClosure *) &$3 = 0x0000000000215eb0
    (int) addr = 2186928
    (int) load_address = 2186928
  }'

I originally did something like this for `expect_expr` and having something like `self.assertIn(subsets, output[:start], "Untruncated output: " + output)` in there helped a lot with debugging.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73766/new/

https://reviews.llvm.org/D73766





More information about the lldb-commits mailing list