[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

Thu Jan 30 21:15:03 PST 2020

jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4011
+void SymbolFileDWARF::GetDWARFDeclContext(const DWARFDIE &die,
+                                          DWARFDeclContext &dwarf_decl_ctx) {
+  if (!die.IsValid()) {
----------------
labath wrote:
> please return the DWARFDeclContext by value here
I did the same also for `DWARFDebugInfoEntry::GetDWARFDeclContext`. It is a part of the updated patch but [[ https://people.redhat.com/jkratoch/GetDWARFDeclContext.patch | you can see it separately ]].

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70646/new/

https://reviews.llvm.org/D70646