[Lldb-commits] [lldb] 457a6d4 - [lldb/Reproducers] Fix typo in CMake so we actually replay.

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 30 15:53:01 PST 2020


Author: Jonas Devlieghere
Date: 2020-01-30T15:51:29-08:00
New Revision: 457a6d49d565075ae99f0e5a931bbed6512dce2f

URL: https://github.com/llvm/llvm-project/commit/457a6d49d565075ae99f0e5a931bbed6512dce2f
DIFF: https://github.com/llvm/llvm-project/commit/457a6d49d565075ae99f0e5a931bbed6512dce2f.diff

LOG: [lldb/Reproducers] Fix typo in CMake so we actually replay.

The CMakeLists.txt had a typo which meant that check-lldb-repro was
capturing twice instead of capturing and then replaying. This also
uncovered a missing import in lldb-repro.py. This patch fixes both
issues.

Added: 
    

Modified: 
    lldb/test/Shell/CMakeLists.txt
    lldb/test/Shell/SymbolFile/DWARF/debug_loc.s
    lldb/utils/lldb-repro/lldb-repro.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/CMakeLists.txt b/lldb/test/Shell/CMakeLists.txt
index c9490d276a4c..e02adb389db2 100644
--- a/lldb/test/Shell/CMakeLists.txt
+++ b/lldb/test/Shell/CMakeLists.txt
@@ -27,6 +27,6 @@ add_lit_testsuite(check-lldb-repro-capture
 add_lit_testsuite(check-lldb-repro
   "Running lldb shell test suite with reproducer replay"
   ${CMAKE_CURRENT_BINARY_DIR}
-  PARAMS "lldb-run-with-repro=capture"
+  PARAMS "lldb-run-with-repro=replay"
   DEPENDS lldb-test-deps)
 add_dependencies(check-lldb-repro check-lldb-repro-capture)

diff  --git a/lldb/test/Shell/SymbolFile/DWARF/debug_loc.s b/lldb/test/Shell/SymbolFile/DWARF/debug_loc.s
index 0892b5f0d2d5..1410ff2674ff 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/debug_loc.s
+++ b/lldb/test/Shell/SymbolFile/DWARF/debug_loc.s
@@ -3,6 +3,7 @@
 # "reasonable".
 
 # REQUIRES: x86
+# UNSUPPORTED: lldb-repro
 
 # RUN: llvm-mc -triple=x86_64-pc-linux -filetype=obj %s --defsym LOC=0 > %t
 # RUN: %lldb %t -o "image lookup -v -a 0" -o "image lookup -v -a 2" \

diff  --git a/lldb/utils/lldb-repro/lldb-repro.py b/lldb/utils/lldb-repro/lldb-repro.py
index f7bcd3baa7a4..fddd65ee093c 100755
--- a/lldb/utils/lldb-repro/lldb-repro.py
+++ b/lldb/utils/lldb-repro/lldb-repro.py
@@ -14,11 +14,12 @@
 recorded session.
 """
 
-import sys
+import hashlib
 import os
-import tempfile
+import shutil
 import subprocess
-import hashlib
+import sys
+import tempfile
 
 
 def help():


        


More information about the lldb-commits mailing list