[Lldb-commits] [lldb] 7a6ebb5 - [lldb] More windows StringRef fixes

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 29 02:15:56 PST 2020


Author: Pavel Labath
Date: 2020-01-29T11:15:20+01:00
New Revision: 7a6ebb5ba3cefef1865a2e0c5f9196101cbd2733

URL: https://github.com/llvm/llvm-project/commit/7a6ebb5ba3cefef1865a2e0c5f9196101cbd2733
DIFF: https://github.com/llvm/llvm-project/commit/7a6ebb5ba3cefef1865a2e0c5f9196101cbd2733.diff

LOG: [lldb] More windows StringRef fixes

I don't have a windows build around, so I am just going by the buildbot
messages.

Added: 
    

Modified: 
    lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
    lldb/source/Host/windows/PipeWindows.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp b/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
index 9f38422d7e3d..817663d6212e 100644
--- a/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
+++ b/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
@@ -127,7 +127,7 @@ lldb::ConnectionStatus ConnectionGenericFile::Connect(llvm::StringRef path,
   }
 
   m_owns_file = true;
-  m_uri.assign(path);
+  m_uri = path.str();
   return eConnectionStatusSuccess;
 }
 

diff  --git a/lldb/source/Host/windows/PipeWindows.cpp b/lldb/source/Host/windows/PipeWindows.cpp
index 873eb51dc682..b63e58e53e7f 100644
--- a/lldb/source/Host/windows/PipeWindows.cpp
+++ b/lldb/source/Host/windows/PipeWindows.cpp
@@ -104,7 +104,7 @@ Status PipeWindows::CreateNew(llvm::StringRef name,
   if (CanRead() || CanWrite())
     return Status(ERROR_ALREADY_EXISTS, eErrorTypeWin32);
 
-  std::string pipe_path = g_pipe_name_prefix;
+  std::string pipe_path = g_pipe_name_prefix.str();
   pipe_path.append(name.str());
 
   // Always open for overlapped i/o.  We implement blocking manually in Read
@@ -182,7 +182,7 @@ Status PipeWindows::OpenNamedPipe(llvm::StringRef name,
   SECURITY_ATTRIBUTES attributes = {};
   attributes.bInheritHandle = child_process_inherit;
 
-  std::string pipe_path = g_pipe_name_prefix;
+  std::string pipe_path = g_pipe_name_prefix.str();
   pipe_path.append(name.str());
 
   if (is_read) {


        


More information about the lldb-commits mailing list