[Lldb-commits] [lldb] d8acf88 - [lldb/Test] Disable command-breakpoint-col.test on Windows

[Pavel Labath via lldb-commits]

On 23/01/2020 23:18, Jonas Devlieghere via lldb-commits wrote:
> 
> Author: Jonas Devlieghere
> Date: 2020-01-23T14:17:50-08:00
> New Revision: d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3
> 
> URL: https://github.com/llvm/llvm-project/commit/d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3
> DIFF: https://github.com/llvm/llvm-project/commit/d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3.diff
> 
> LOG: [lldb/Test] Disable command-breakpoint-col.test on Windows
> 
> I guess PDB doesn't have column information?
> 

Yes, it probably doesn't. But since you don't actually run this program,
this is one of those tests where it might be better/more
predictible/reliable to use "%clang -c -target some-target" instead of
%clang_host

> 
> Modified: 
>     lldb/test/Shell/Commands/command-breakpoint-col.test
> 
> Removed: 
>     
> 
> 
> ################################################################################
> diff  --git a/lldb/test/Shell/Commands/command-breakpoint-col.test b/lldb/test/Shell/Commands/command-breakpoint-col.test
> index 3ffa673e8305..65e66a362a59 100644
> --- a/lldb/test/Shell/Commands/command-breakpoint-col.test
> +++ b/lldb/test/Shell/Commands/command-breakpoint-col.test
> @@ -1,3 +1,5 @@
> +# UNSUPPORTED: system-windows
> +#
>  # RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out
>  # RUN: %lldb -b -o 'help breakpoint set' -o 'breakpoint set -f main.c -l 2 -u 21' %t.out | FileCheck %s
>  # CHECK: -u <column> ( --column <column> )
> 
> 
>         
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>